Allow to customize OIDC JavaRequest checks #34812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
gastaldi
approved these changes
Jul 18, 2023
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
|
Thanks @gastaldi, let me apply |
sberyozkin
force-pushed
the
oidc_javascript_checker
branch
from
c303b99
to
9ef513e
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about making it easier for SPA developers to tell Quarkus that XHR/Fetch issued the call - currently they have to set up a header in the script - but if the script engine already sets some header of its own then making this check from a custom
JavaScriptRequestCheckerbean simplifies the scripts, avoids the creation of redundant headers.This PR is only about supporting this check at the server side. As documented, SPA may need to reload the page if Keycloak or other providers do not support CORS in their authorization endooints - so Quarkus can help with issuing 499 error (instead of redirects) if it is allowed to do so for JavaScript requests - SPA catch it and reload the page bypassing CORS restrictions in Keycloak.
So
JavaScriptRequestCheckeris introduced, tests and docs updated.